Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source 4 Explicit-Control: Unable to terminate the program after playing a sound #1509

Open
Ziwen510 opened this issue Dec 1, 2023 · 0 comments
Labels
Bug Something isn't working

Comments

@Ziwen510
Copy link
Contributor

Ziwen510 commented Dec 1, 2023

In the Explicit-Control variant of Source 4, the program fails to terminate properly after executing a "play" function in the sound module. This malfunction presents as a lack of output and results in a website crash, specifically due to an "out of memory" error.

To reproduce:
import {play, make_sound} from "sound"; play(make_sound(x => math_sin(440 * 2 * x * math_PI), 2));

Possible reason:
It appears that the ECE interpreter is prematurely concluding its evaluation process, while the sound processing is not fully complete.

Possible solution:
Implement an asynchronous operation for the interpreter.

@Ziwen510 Ziwen510 added the Bug Something isn't working label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant