Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new variant: Source 2 WGSL #1511

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

Add new variant: Source 2 WGSL #1511

wants to merge 26 commits into from

Conversation

Ziwen510
Copy link
Contributor

@Ziwen510 Ziwen510 commented Dec 5, 2023

Description

Source §2 WGSL utilizes the WebGPU API to accelerate GPU-based operations for Source programs. This modern web standard enables efficient rendering and data processing directly from web browsers. Specifically, in Source §2 WGSL, when a Source program invokes the play function from the Sound module, the wave function of the sound to be played undergoes partial evaluation and is transpiled into the WebGPU Shading Language (WGSL). This process significantly enhances sound processing speed on the GPU using WebGPU APIs.

Changes

  • Source code and testing for this interpreter are under src/wgsl
  • Documentation and specs for this new variant.

@Ziwen510 Ziwen510 added the Enhancement New feature or request label Dec 5, 2023
@Ziwen510 Ziwen510 self-assigned this Dec 5, 2023
@Ziwen510 Ziwen510 linked an issue Dec 5, 2023 that may be closed by this pull request
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coveralls
Copy link

coveralls commented Dec 5, 2023

Pull Request Test Coverage Report for Build 8408397023

Details

  • 458 of 621 (73.75%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 80.702%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/wgsl/types.ts 27 31 87.1%
src/wgsl/lib.ts 9 18 50.0%
src/wgsl/utils.ts 119 129 92.25%
src/wgsl/webgpu/initDevice.ts 2 18 11.11%
src/wgsl/operations.ts 17 34 50.0%
src/wgsl/webgpu/play_gpu.ts 2 40 5.0%
src/wgsl/interpreter.ts 237 306 77.45%
Totals Coverage Status
Change from base Build 8405750861: -0.3%
Covered Lines: 10963
Relevant Lines: 13185

💛 - Coveralls

@martin-henz
Copy link
Member

@Ziwen510 can you take a look at the merge conflicts? It would probably not take much of your time to fix these so that the review can proceed. Tx.

@Ziwen510
Copy link
Contributor Author

Ziwen510 commented Mar 12, 2024

@martin-henz @JoelChanZhiYang Merge conflicts are all resolved! Feel free to ask me for any other problems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prof @martin-henz should we adapt the terminology here as well to reflect the updates to what's now the CSE Machine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should. Thanks for spotting this.

@martin-henz martin-henz marked this pull request as draft March 24, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new variant: Source 2 WGSL
4 participants