Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove src/interpreter/interpreter-non-det.ts (currently not working anyway) #1695

Open
martin-henz opened this issue Apr 27, 2024 · 2 comments · May be fixed by #1707
Open

Remove src/interpreter/interpreter-non-det.ts (currently not working anyway) #1695

martin-henz opened this issue Apr 27, 2024 · 2 comments · May be fixed by #1707
Labels
Bug Something isn't working Enhancement New feature or request

Comments

@martin-henz
Copy link
Member

Remove all of src/interpreter once source-academy/sicp#990 is resolved.

Currently, Source §3 Non-Det is not working. Older version works. E.g. the first example in SICP JS 4.3
https://sourceacademy.nus.edu.sg/sicpjs/4.3.1
works without error (but with spacing issues). (currently deployment of SA@NUS of today)

The newest version in SA.org gives a runtime error:
https://share.sourceacademy.org/s9irv
gives:

main.13f449e4.js:2 RangeError: Maximum call stack size exceeded
This is regardless whether the amb operator is used.

display(1);
gives the same error. Source §3 Non-Det does not work at all, currently.

@martin-henz martin-henz added Bug Something isn't working Enhancement New feature or request labels Apr 27, 2024
@RichDom2185
Copy link
Member

Is this a duplicate of #1476?

@martin-henz martin-henz changed the title Remove src/interpreter (currently not working anyway) Remove src/interpreter/interpreter-non-det.ts (currently not working anyway) Apr 27, 2024
@martin-henz
Copy link
Member Author

Is this a duplicate of #1476?

No, it's in addition to #1476. I've clarified the title of this issue.

@leeyi45 leeyi45 linked a pull request May 22, 2024 that will close this issue
@RichDom2185 RichDom2185 linked a pull request May 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants