You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because our testing utilities relied heavily on the interpreter, removing it means touching almost every single part of js-slang, hence the ridiculous number of lines changed. I've tried to simplify the testing utilities and refactor repetitive code where necessary without breaking anything I hope. For example, I noticed that the stepper's tests were being run as async tests when getEvaluationSteps is no longer asynchronous. Hopefully with these changes it will make such things easier to catch.
I've also configured tsconfig.prod.json to exclude src/utils/testing. Previously this code was being shipped with the rest of js-slang, but given that we only use it for unit testing I don't think it should be included when js-slang is being built.
Given that @martin-henz has indicated that other parts of js-slang are marked for removal, I decided to remove them here to avoid having to refactor the tests for those parts of js-slang.
Please refer to the TODO comments to see what issues need to be addressed before this PR can be merged.
This remains a draft because there are some critical questions that need to be answered:
Since svml-machine.ts is removed, we need to specify the behaviour for when runInContext is called with Variant.CONCURRENT. The variant has been left in since there are parts of the vm that still rely on it.
String representations of functions in the cse-machine always default to arrow functions. Is this desired behaviour? Because currently the native runner and the cse-machine have different behaviour.
I am wholly unqualified to update src/__tests__/environment.ts. So the snapshot is failing here but I haven't just gone ahead and changed it.
Stepper doesn't actually do type checking: 0 / "a"; doesn't cause it to throw errors. Does something need to be done about this?
One more thing: I have no idea what inspect() or any of those related things do, so I haven't been able to remove things like the Scheduler
Ideally I'd like to remove things like manualToggleDebugger since it doesn't seem like we're using it anymore
I went back to check my 4th point cause it did seem a bit weird to me. I think what I was trying to say is that the stepper will happily evaluate up to the point of a runtime error and js-slang returns a non-errored result value (because the error itself is a step)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL; DR
svml-machine.tsjs-slangtests more robust and simplerWhat's going on:
Because our testing utilities relied heavily on the interpreter, removing it means touching almost every single part of
js-slang, hence the ridiculous number of lines changed. I've tried to simplify the testing utilities and refactor repetitive code where necessary without breaking anything I hope. For example, I noticed that the stepper's tests were being run as async tests whengetEvaluationStepsis no longer asynchronous. Hopefully with these changes it will make such things easier to catch.I've also configured
tsconfig.prod.jsonto excludesrc/utils/testing. Previously this code was being shipped with the rest ofjs-slang, but given that we only use it for unit testing I don't think it should be included whenjs-slangis being built.Given that @martin-henz has indicated that other parts of
js-slangare marked for removal, I decided to remove them here to avoid having to refactor the tests for those parts ofjs-slang.Please refer to the TODO comments to see what issues need to be addressed before this PR can be merged.
Will resolve these issues:
src/interpreter/interpreter-non-det.ts(currently not working anyway) #1695src/lazy#1696src/vm/svml-machine.ts#1697Some issues that need to be revisited: