Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payment-service): fix issues in payment service #2139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(payment-service): fix issues in payment service #2139

wants to merge 3 commits into from

Conversation

Surbhi-sharma1
Copy link
Contributor

fix issues in payment service

GH-2138

Description

Fixes #2138

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Surbhi-sharma1 Surbhi-sharma1 requested a review from a team as a code owner July 31, 2024 10:43
yeshamavani
yeshamavani requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@yeshamavani yeshamavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the APIspec of this service improved

services/payment-service/README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention in the README the order in which the APIs will be invoked for end to end complete payment transaction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

services/payment-service/src/component.ts Outdated
@@ -110,7 +110,7 @@ export class PaymentServiceComponent implements Component {
Binding.bind(PayPalBindings.PayPalHelper.key).to(null),
];
this.application.component(CoreComponent);

this.application.component(TenantUtilitiesComponent);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was giving tenant guard Service related errors.

services/payment-service/src/controllers/subscriptions-transactions.controller.ts
Comment on lines +96 to +104
@authenticate(STRATEGY.BEARER)
@authorize({
permissions: [
PermissionKey.UpdateTransaction,
PermissionKey.UpdateTransactionNum,
],
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR marked as breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as draft August 1, 2024 04:17
@Surbhi-sharma1
fix(payment-service): fix payment service issues
7f318ad 
fix payment service issues

BREAKING CHANGE:
Added mandatory authentication and authorization checks to API endpoints

GH-2138
@Surbhi-sharma1
docs(payment-service): updated readme
d815228 
BREAKING CHANGE:
Added mandatory authentication and authorization checks to API endpoints.

GH-2138
@Surbhi-sharma1
fix(payment-service): fix migration
6cdd9de 
MIGRATION CHANGE:
migration-20210722063857- fix migration

GH-2138
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as ready for review August 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeshamavani yeshamavani yeshamavani requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sourceloop/payment-service:fix issues of payment service
2 participants
@Surbhi-sharma1 @yeshamavani