Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not binding Ctrl+Y (commonly "Redo") to "Sourcery: Ask Sourcery" aka sourcery.chat.ask #204

Closed
blakeNaccarato opened this issue Aug 16, 2023 · 6 comments · Fixed by #224

Comments

@blakeNaccarato
Copy link

I see there are some variations on Ctrl+Y in your package.json keybind for sourcery.chat.ask. I don't know exactly why, perhaps it's related to me having had settingsSync.keybindingsPerPlatform disabled in settings.json as a workaround for another issue I once encountered, but sourcery.chat.ask was bound to Ctrl+Y for me, even on Windows.

Anyways, I think this choice of keybinding conflicts with the very common Ctrl+Y keybinding for "Redo" that I imagine many users will have. Could your team consider not binding Ctrl+Y to this command, as it hijacked my "Redo" today, which was very surprising. I've unbound it manually, but it would be nice not to bind this particular keyboard combination by default. Thanks!

@koeppe-at-pdtec
Copy link

Hello, same problem here. I was wondering why ctrl+y stoppend working out of nowhere. Took me while to find out it was resused by the extension.
I also vote for not overwriting any vscode default keyboard shortcuts.

@ma7555
Copy link

ma7555 commented Sep 17, 2023

Agreed. This is not practical

@JeremyFields
Copy link

Having the same issue. What is the best way to change the keyboard shortcut for Sourcery to not use CTRL+Y ? Having to use the mouse to go to "Edit, Redo" is qutie annoying.

@brendanator
Copy link
Contributor

Sorry about this.

We set the Windows shortcut to ctrl+shift+y specifically to avoid this clash, so I'm not entirely sure why it's happening. One possibility is that some of you are using WSL where we set the shortcut to ctrl+y? Either way I'll change the shortcut to ctrl+shift+y in Linux too just in case this is the cause of the issue

This will come in our next release

@blakeNaccarato
Copy link
Author

Yes, I thought it strange as well that the Linux keybind "poisoned" my Windows bind. I've left a comment in your PR with some details I found.

@koeppe-at-pdtec
Copy link

Hello,

the assumtion that WSL is the cause might be correct. I'm using vscode with WSL and the wsl extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants