From 8b6ba805291aaeb9f38c165e56dea7979e1426c8 Mon Sep 17 00:00:00 2001
From: Connor Tumbleson <iBotPeaches@users.noreply.github.com>
Date: Mon, 6 Jan 2025 09:46:10 -0500
Subject: [PATCH] PHP 8.4 Support (#26)

* build: support php8.4

* chore: pint v1.19.0
---
 .github/workflows/main.yml     |  2 +-
 composer.json                  |  4 ++--
 src/SoapyCurtain.php           | 12 ++++++------
 tests/BaseTestCase.php         |  2 +-
 tests/Unit/CustomClassTest.php |  4 ++--
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 1451d63..9b99ec0 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [8.2, 8.3]
+        php: [8.2, 8.3, 8.4]
         laravel: [11.0]
     name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }}
     steps:
diff --git a/composer.json b/composer.json
index 569e5bf..dde8070 100644
--- a/composer.json
+++ b/composer.json
@@ -15,7 +15,7 @@
         }
     ],
     "require": {
-        "php": "^8.2",
+        "php": "^8.2||^8.3||^8.4",
         "ext-simplexml": "*",
         "ext-soap": "*",
         "illuminate/support": "^11"
@@ -23,7 +23,7 @@
     "require-dev": {
         "orchestra/testbench": "^9.2",
         "phpunit/phpunit": "^11.2",
-        "laravel/pint": "^1.17"
+        "laravel/pint": "^1.19"
     },
     "autoload": {
         "psr-4": {
diff --git a/src/SoapyCurtain.php b/src/SoapyCurtain.php
index 0bdbb05..eedca5f 100644
--- a/src/SoapyCurtain.php
+++ b/src/SoapyCurtain.php
@@ -24,7 +24,7 @@ class SoapyCurtain
 
     protected array $typeMap = [];
 
-    //region getters
+    // region getters
 
     public function getWsdl(): ?string
     {
@@ -96,9 +96,9 @@ public function getTypemap(): ?array
         return $this->typeMap;
     }
 
-    //endregion
+    // endregion
 
-    //region setters
+    // region setters
 
     public function setWsdl(string $wsdl): self
     {
@@ -194,9 +194,9 @@ public function addTypeMap(string $namespace, string $item, \Closure $fromXml):
         return $this;
     }
 
-    //endregion
+    // endregion
 
-    //region functions
+    // region functions
 
     public function isReady(): bool
     {
@@ -207,5 +207,5 @@ public function isReady(): bool
         return ! empty($this->getWsdl());
     }
 
-    //endregion
+    // endregion
 }
diff --git a/tests/BaseTestCase.php b/tests/BaseTestCase.php
index 2895231..cfbacfc 100644
--- a/tests/BaseTestCase.php
+++ b/tests/BaseTestCase.php
@@ -10,7 +10,7 @@ class BaseTestCase extends TestCase
 {
     protected $baseWsdl;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
         $this->baseWsdl = __DIR__.'/example.wsdl';
diff --git a/tests/Unit/CustomClassTest.php b/tests/Unit/CustomClassTest.php
index 0e753f0..06c778a 100644
--- a/tests/Unit/CustomClassTest.php
+++ b/tests/Unit/CustomClassTest.php
@@ -13,7 +13,7 @@
 
 class CustomClassTest extends BaseTestCase
 {
-    public function testCreatingClientWithNoCustomOverload()
+    public function test_creating_client_with_no_custom_overload()
     {
         $client = SoapyFacade::create(function (SoapyCurtain $curtain) {
             return $curtain
@@ -24,7 +24,7 @@ public function testCreatingClientWithNoCustomOverload()
         $this->assertInstanceOf(SoapyBaseClient::class, $client);
     }
 
-    public function testCreatingClientWithCustomOverload()
+    public function test_creating_client_with_custom_overload()
     {
         $baseClient = TestSoapyClient::class;