Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pool size must be optional #1000

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix: Pool size must be optional #1000

merged 2 commits into from
Jul 18, 2024

Conversation

ununhexium
Copy link
Collaborator

@ununhexium ununhexium commented Jul 18, 2024 •
edited
Loading

Fix a problem when starting the EDC without the max connection pool size property.

The timeout property doesn't need to be exposed to sysadmins.

Checklist
Beta Give feedback

@ununhexium ununhexium changed the title RM timeout property and add pool size property requirement fix: Pool size must be optional Jul 18, 2024
kamilczaja
kamilczaja requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@kamilczaja kamilczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on PR number 1000!
However, adjust changelog please

CHANGELOG.md Outdated Show resolved Hide resolved
@ununhexium ununhexium enabled auto-merge (squash) July 18, 2024 12:56
kamilczaja
kamilczaja approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@kamilczaja kamilczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ununhexium ununhexium merged commit 1687477 into main Jul 18, 2024
18 checks passed
@ununhexium ununhexium deleted the update-docker-compose branch July 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilczaja kamilczaja kamilczaja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ununhexium @kamilczaja