Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time specifications within policies are not accurate #815

Closed
5 tasks done
tmberthold opened this issue Aug 14, 2024 · 0 comments · Fixed by #832
Closed
5 tasks done

Time specifications within policies are not accurate #815

tmberthold opened this issue Aug 14, 2024 · 0 comments · Fixed by #832
Assignees
Labels
bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. component/edc-ui affected software component kind/bug Something isn't working. The software does not behave as expected or specified. scope/mds related to MDS
Milestone

Comments

@tmberthold
Copy link

tmberthold commented Aug 14, 2024

Description - What happened? *

Original Issue:
when creating policy with time span or evaluation time and operators "<=" or ">" [etc.] are used the restriction should consider the end of the day time so for example if we say be valid <= 14th it should be valid until 14th end of day

Expected Behavior *

Create a policy that requires operators to work properly within a certain time span

Observed Behavior *

Users are confused by the fact that their policy-times are not transformed correctly.

Steps to Reproduce

Steps to reproduce the behavior:

  • Create policy with timespan operators using "<=" or ">" etc.

Context Information

No response

Relevant log output

No response

Screenshots

In the following example, the user expects the time to include 17.08.24 until EOD because of <=, but in fact however it is only until 16.08.24 at 10pm. The information provided by the user and the user's understanding do not match the way it is then evaluated.

image

Proposed Solution by RT

  • Right now already: There is a display text that is currently the "abbreviated" local date, and the tooltip shows the raw JSON
  • We want to fix the display text function.
  • Only round to a local date, iff: In local time the date is exactly midnight
  • For upper bound comparisons (<, <=) calculate the day minus one
  • The display text should be in local time
@tmberthold tmberthold added the kind/bug Something isn't working. The software does not behave as expected or specified. label Aug 14, 2024
@tmberthold tmberthold added this to the MDS 2.2 milestone Aug 14, 2024
@tmberthold tmberthold added bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. scope/mds related to MDS labels Aug 14, 2024
@ununhexium ununhexium added the component/edc-ui affected software component label Aug 14, 2024
@AbdullahMuk AbdullahMuk assigned illfixit and unassigned kamilczaja Aug 23, 2024
@illfixit illfixit linked a pull request Aug 28, 2024 that will close this issue
@tmberthold tmberthold transferred this issue from sovity/edc-ce Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. component/edc-ui affected software component kind/bug Something isn't working. The software does not behave as expected or specified. scope/mds related to MDS
Projects
None yet
5 participants