diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index eecee25f95d..6f4c3ffc09d 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -932,6 +932,9 @@ The following sequence diagram shows how the different components of UniCa$h int +
+**Note:** The lifeline for `EditTransactionCommandParser` should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram. +
##### Details @@ -1213,8 +1216,6 @@ This command will exit UniCa$h. ### User Interface -#### Summary Statistics - [//]: # (#### etc) ### Minor Features diff --git a/docs/diagrams/unicash/EditTransactionSequenceDiagram.puml b/docs/diagrams/unicash/EditTransactionSequenceDiagram.puml index 5371a6ab730..206ae684181 100644 --- a/docs/diagrams/unicash/EditTransactionSequenceDiagram.puml +++ b/docs/diagrams/unicash/EditTransactionSequenceDiagram.puml @@ -56,6 +56,7 @@ deactivate EditTransactionCommandParser UniCashParser --> LogicManager : command deactivate UniCashParser +destroy EditTransactionCommandParser LogicManager -> EditTransactionCommand : execute(model) activate EditTransactionCommand diff --git a/docs/images/unicash/EditTransactionSequenceDiagram.png b/docs/images/unicash/EditTransactionSequenceDiagram.png index a1ab9ecb7c9..c8d868273a6 100644 Binary files a/docs/images/unicash/EditTransactionSequenceDiagram.png and b/docs/images/unicash/EditTransactionSequenceDiagram.png differ diff --git a/docs/team/elhy1999.md b/docs/team/elhy1999.md index 37d357aa8d1..47aa5b2c8b9 100644 --- a/docs/team/elhy1999.md +++ b/docs/team/elhy1999.md @@ -37,7 +37,8 @@ Given below are my contributions to the project. * **Community**: - * PRs reviewed (with non-trivial review comments): [[PR #56](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/56)], [[PR #87](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/87)], [[PR #141](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/141)] + * PRs reviewed (with non-trivial review comments): [[PR #56](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/56)], [[PR #87](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/87)], [[PR #141](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/141)], [[PR #214](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/214)] + * All PRs reviewed can be found [here](https://github.com/AY2324S1-CS2103-T16-3/tp/pulls?q=is%3Apr+reviewed-by%3Aelhy1999) * Non-trivial bugs found in other team's projects: [[Issue #131](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/131)], [[Issue #142](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/142)], [[Issue #149](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/149)], [[Issue #163](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/163)], [[Issue #125](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/125)] * **Tools**: diff --git a/src/main/java/unicash/ui/SummaryWindow.java b/src/main/java/unicash/ui/SummaryWindow.java index 6855099d52a..7362f85a1c7 100644 --- a/src/main/java/unicash/ui/SummaryWindow.java +++ b/src/main/java/unicash/ui/SummaryWindow.java @@ -138,6 +138,7 @@ public void setLineGraph(HashMap expenseSummary) { * or EARLIEST_YEAR_MONTH */ private static boolean isValidYearMonth(YearMonth yearMonth) { + assert yearMonth != null : "yearMonth cannot be null"; boolean afterMostRecentYearMonth = yearMonth.compareTo(EARLIEST_YEAR_MONTH) >= 0; boolean beforeCurrentYearMonth = yearMonth.compareTo(LATEST_YEAR_MONTH) <= 0; return afterMostRecentYearMonth & beforeCurrentYearMonth;