Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check fails to resolve commits in forks #3

Closed
Bckempa opened this issue Oct 3, 2024 · 2 comments · Fixed by #4
Closed

Check fails to resolve commits in forks #3

Bckempa opened this issue Oct 3, 2024 · 2 comments · Fixed by #4
Assignees
@eholum
Labels
bug Something isn't working
Milestone
humble-2024.10.0

Comments

@Bckempa
Copy link

Bckempa commented Oct 3, 2024

BTW, @EzraBrooks I can see that the commit message CI checker failed. I believe its because I opened pull request from my own repo. I think this CI check should be fixed, wdyt? All the PRs that were merged after adding this check were opened from space-ros/docker repo, and I believe that is why CI was green for them.

Originally posted by @xfiderek in space-ros/docker#152 (comment)
@Bckempa
Copy link
Author

Bckempa commented Oct 3, 2024

Sticking @EzraBrooks with this (feel free to delegate 😉) since he was the original author.

@Bckempa Bckempa added this to the jazzy-2024.10.0 milestone Oct 3, 2024
@Bckempa Bckempa added the bug Something isn't working label Oct 3, 2024
@eholum eholum assigned eholum and unassigned EzraBrooks Oct 21, 2024
eholum added a commit to eholum/check-commit-message-action that referenced this issue Oct 21, 2024
@eholum
Fetch history for the ref instead of relying on the origin (issue spa…
5c21859 
…ce-ros#3)
@eholum eholum mentioned this issue Oct 21, 2024
Merged
eholum added a commit to eholum/check-commit-message-action that referenced this issue Oct 21, 2024
@eholum
Fetch history for the PR ref instead of relying on the origin (issue s…
6e1f20d 
…pace-ros#3)
@eholum
Copy link
Contributor

eholum commented Oct 21, 2024

Volun-delegated to me, should be fixed (possibly in a silly, silly way) by #4

@eholum eholum moved this from Todo to In Review in Space ROS Project Development Oct 21, 2024
@eholum eholum closed this as completed in #4 Oct 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Space ROS Project Development Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eholum eholum

Labels
bug Something isn't working
Projects
Space ROS Project Development
Status: Done
Milestone
humble-2024.10.0
Development

Successfully merging a pull request may close this issue.

Grab commit history from PR branch to support forks eholum/check-commit-message-action
3 participants
@EzraBrooks @Bckempa @eholum