Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moveit2 patch of octomap_msgs CMake no longer needed as of 2.0.1 #203

Open
gmacario opened this issue Nov 17, 2024 · 2 comments · May be fixed by #204
Open

Moveit2 patch of octomap_msgs CMake no longer needed as of 2.0.1 #203

gmacario opened this issue Nov 17, 2024 · 2 comments · May be fixed by #204
Assignees
@Bckempa
Labels
bug Something isn't working
Milestone
jazzy-2025.01.0

Comments

@gmacario
Copy link

Version or commit hash

045f144

RMW Implementation

FastRTPS

Steps to reproduce issue

Look at the status of recent builds https://github.com/space-ros/docker/actions/workflows/docker-build.yml

Expected behavior

The workflow should be successful

Actual behavior

Sample output from https://github.com/space-ros/docker/actions/runs/11875378261

image

Backtrace or Console output

Detail from https://github.com/space-ros/docker/actions/runs/11875378261:

space_robots
buildx failed with: ERROR: failed to solve: process "/bin/sh -c cd src/octomap_msgs && git apply octomap_fix.diff" did not complete successfully: exit code: 1
@gmacario gmacario added the bug Something isn't working label Nov 17, 2024
@Bckempa
Copy link
Contributor

Bckempa commented Nov 17, 2024

Looks like the patch to the octomap_msgs package CMakeLists.txt in commit 7d60962 was added upstream by commit 16af48e which was added two years ago but only tagged in a release on the ros2 branch with version 2.0.1 last week.

Since the moveit2-pkgs is unversioned on the main branch, this new version started breaking the build.

@Bckempa Bckempa self-assigned this Nov 17, 2024
@Bckempa Bckempa moved this to In Progress in Space ROS Project Development Nov 17, 2024
@Bckempa Bckempa added this to the jazzy-2025.01.0 milestone Nov 17, 2024
@Bckempa Bckempa changed the title Workflow "Docker build" keeps failing since last week Moveit2 patch of octomap_msgs CMake no longer needed as of 2.0.1 Nov 17, 2024
Bckempa added a commit that referenced this issue Nov 17, 2024
@Bckempa
Remove upstreamed patch to octomap_msgs (#203)
9042e7f 
Fixed upstream by [16af48e](OctoMap/octomap_msgs@16af48e)
Released in [`octomap_msgs` version `2.0.1`](https://github.com/OctoMap/octomap_msgs/releases/tag/2.0.1)
@Bckempa Bckempa linked a pull request Nov 17, 2024 that will close this issue
Remove upstreamed patch to octomap_msgs (fixes #203) #204
Open
@Bckempa
Copy link
Contributor

Bckempa commented Nov 17, 2024

I opened #204 with a quick fix to remove the unnecessary patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bckempa Bckempa

Labels
bug Something isn't working
Projects
Space ROS Project Development
Status: In Progress
Milestone
jazzy-2025.01.0
Development

Successfully merging a pull request may close this issue.

Remove upstreamed patch to octomap_msgs (fixes #203) space-ros/docker
2 participants
@gmacario @Bckempa