Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address the TODO OOP criticism section #82

Closed
AlbertSnows opened this issue Oct 17, 2023 · 2 comments
Closed

Address the TODO OOP criticism section #82

AlbertSnows opened this issue Oct 17, 2023 · 2 comments
Labels
Content Relevant to documentation of Space Station 14-specific code. Engine Relevant to documentation of Robust Toolbox-specific code, not content. Guides/Onboarding Related to guide/tutorial documentation and/or onboarding/developer setup Meta Related to the docs site styling or feature requests, not the actual documentation.

Comments

@AlbertSnows
Copy link
Contributor

In the ECS section we have "TODO: finish this" which reflects on some challenges of implementing an OOP style code base for SS14. We should clean this section up at minimum and hopefully add additional details later.
@AlbertSnows
Copy link
Contributor Author

I have already done this, just making an issue for it. I will create a PR and reference this issue shortly.

@AlbertSnows AlbertSnows mentioned this issue Oct 17, 2023
Closed
@Jezithyr Jezithyr added Content Relevant to documentation of Space Station 14-specific code. Engine Relevant to documentation of Robust Toolbox-specific code, not content. Meta Related to the docs site styling or feature requests, not the actual documentation. Guides/Onboarding Related to guide/tutorial documentation and/or onboarding/developer setup labels Mar 4, 2024
@Jezithyr Jezithyr mentioned this issue Mar 4, 2024
Open
@Jezithyr
Copy link
Contributor

Jezithyr commented Mar 4, 2024

dupe of #15

@Jezithyr Jezithyr closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content Relevant to documentation of Space Station 14-specific code. Engine Relevant to documentation of Robust Toolbox-specific code, not content. Guides/Onboarding Related to guide/tutorial documentation and/or onboarding/developer setup Meta Related to the docs site styling or feature requests, not the actual documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ecs.md AlbertSnows/docs
2 participants
@Jezithyr @AlbertSnows