From c807dc3b2ad1ff5ba276634e4317226d390d2447 Mon Sep 17 00:00:00 2001 From: Jacob Trombetta Date: Mon, 18 Nov 2024 09:44:42 -0500 Subject: [PATCH 1/2] doc: specify the jaeger all-in-one docker image version to avoid bug in the latest version --- crates/proof-of-sql/benches/jaeger_benches.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/proof-of-sql/benches/jaeger_benches.rs b/crates/proof-of-sql/benches/jaeger_benches.rs index 77ac08288..7bdd9aa3d 100644 --- a/crates/proof-of-sql/benches/jaeger_benches.rs +++ b/crates/proof-of-sql/benches/jaeger_benches.rs @@ -1,7 +1,7 @@ //! Benchmarking/Tracing using Jaeger. //! To run, execute the following commands: //! ```bash -//! docker run --rm -d --name jaeger -p 6831:6831/udp -p 16686:16686 jaegertracing/all-in-one:latest +//! docker run --rm -d --name jaeger -p 6831:6831/udp -p 16686:16686 jaegertracing/all-in-one:1.62.0 //! cargo bench -p proof-of-sql --bench jaeger_benches InnerProductProof //! cargo bench -p proof-of-sql --bench jaeger_benches Dory //! cargo bench -p proof-of-sql --bench jaeger_benches DynamicDory From 51e127019b972e5e5ed8eea9716d29f795865047 Mon Sep 17 00:00:00 2001 From: Jacob Trombetta Date: Mon, 18 Nov 2024 09:48:33 -0500 Subject: [PATCH 2/2] doc: update readme to specify the jaeger all-in-one docker image version --- crates/proof-of-sql/benches/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/proof-of-sql/benches/README.md b/crates/proof-of-sql/benches/README.md index 8d7b58fcb..61440e1b6 100644 --- a/crates/proof-of-sql/benches/README.md +++ b/crates/proof-of-sql/benches/README.md @@ -6,7 +6,7 @@ To run benchmarks with Jaeger, you need to do the following 1. Spin up Jaeger service on port 6831 to receive the benchmarks trace data, and provides Jaeger UI on port 16686. ```bash - docker run --rm -d --name jaeger -p 6831:6831/udp -p 16686:16686 jaegertracing/all-in-one:latest + docker run --rm -d --name jaeger -p 6831:6831/udp -p 16686:16686 jaegertracing/all-in-one:1.62.0 ``` 2. Run a benchmark. ```bash