Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce v2beta1 and migrate v2alpha1 POST API calls to GET #6636

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Introduce v2beta1 and migrate v2alpha1 POST API calls to GET #6636

wants to merge 3 commits into from

Conversation

kacpersaw
Copy link
Contributor

Description

Closes #6630

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.47601% with 409 lines in your changes missing coverage. Please review.

Project coverage is 79.8%. Comparing base (ffdf627) to head (78e0384).
Report is 5 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/grpcserver/v2beta1/malfeasance.go 60.6% 83 Missing and 21 partials ⚠️
api/grpcserver/v2beta1/transaction.go 78.4% 62 Missing and 20 partials ⚠️
api/grpcserver/v2beta1/activation.go 70.4% 63 Missing and 13 partials ⚠️
api/grpcserver/v2beta1/layer.go 71.6% 55 Missing and 8 partials ⚠️
api/grpcserver/v2beta1/reward.go 70.9% 54 Missing and 9 partials ⚠️
api/grpcserver/v2beta1/account.go 83.7% 11 Missing and 3 partials ⚠️
api/grpcserver/v2beta1/node.go 82.7% 4 Missing and 1 partial ⚠️
api/grpcserver/v2beta1/network.go 91.3% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #6636     +/-   ##
=========================================
- Coverage     80.0%   79.8%   -0.2%     
=========================================
  Files          358     366      +8     
  Lines        47999   49541   +1542     
=========================================
+ Hits         38411   39558   +1147     
- Misses        7416    7741    +325     
- Partials      2172    2242     +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak will be requested when the pull request is marked ready for review dshulyak is a code owner

@fasmat fasmat Awaiting requested review from fasmat fasmat will be requested when the pull request is marked ready for review fasmat is a code owner

@poszu poszu Awaiting requested review from poszu poszu will be requested when the pull request is marked ready for review poszu is a code owner

@ivan4th ivan4th Awaiting requested review from ivan4th ivan4th will be requested when the pull request is marked ready for review ivan4th is a code owner

@jellonek jellonek Awaiting requested review from jellonek jellonek will be requested when the pull request is marked ready for review jellonek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce v2beta1 and migrate v2alpha1 POST API calls to GET
1 participant
@kacpersaw