Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[model.py] Refactor to use astropy.modeling or at least a class #32

Open
pllim opened this issue Nov 24, 2020 · 0 comments
Open

[model.py] Refactor to use astropy.modeling or at least a class #32

pllim opened this issue Nov 24, 2020 · 0 comments
Labels
enhancement New feature or request Needs discussions

Comments

@pllim
Copy link
Collaborator

pllim commented Nov 24, 2020 •
edited
Loading

Currently, the instruction is to create two functions for each model (#26). Why can't we:

  1. Make each model a class with constructor taking fundamental inputs (arrays, etc) and a separate class method to take TCE?
  2. Inherit from astropy.modeling.models base class by taking advantage of its ability to specify custom models.
  3. And if we want to enable the machinery beyond boxcar and trapezoid, define an abstract base class for all models (existing and future).
@pllim pllim added enhancement New feature or request Needs discussions labels Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Needs discussions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pllim