Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: LPP vetter needs to play nice with refactored Tce class #35

Open
pllim opened this issue Nov 24, 2020 · 0 comments
Open

BUG: LPP vetter needs to play nice with refactored Tce class #35

pllim opened this issue Nov 24, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@pllim
Copy link
Collaborator

pllim commented Nov 24, 2020

Follow up of #26 and #33 .

This needs fixing:

exovetter/exovetter/lpp.py

Lines 351 to 356 in c8b64ef

# FIXME: This looks more correct but fails the test.
# from exovetter import const as exo_const
# self.tzero = tce.get_epoch(
# getattr(exo_const, lc.time_format)).to_value(u.day)
self.tzero = tce['epoch'].to_value(u.day)

This test needs to be updated:

tzero = (54953.6193 + 2400000.5 - 2454833.0) * u.day

But I don't know what is going on with tzero in the test, so maybe @mustaric or @fergalm can fix it properly.

@pllim pllim added the bug Something isn't working label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant