New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting input and output frames to the same type without explicit names causes conflict #327

Open

Cadair opened this issue Nov 11, 2020 · 1 comment

Milestone

Collaborator

Cadair commented Nov 11, 2020

Take for example this:

w = WCS(forward_transform=m.Tabular1D(points=np.arange(10)*u.pix,
                                      lookup_table=np.arange(10)*u.km),
        output_frame=frame,
        input_frame=cf.CoordinateFrame(1, "PIXEL", (0,), unit=(u.pix,))
        )
w.world_to_pixel(0*u.km)

The w.input_frame property returns the output frame because they have the same name (defaults to the name of the class).

The text was updated successfully, but these errors were encountered:

Cadair added a commit to Cadair/gwcs that referenced this issue


          Fix test fail to work around spacetelescope#327

117b769

nden mentioned this issue

Unnamed coordinate frames of the same type cause bounding_box error #398

Closed

Collaborator Author

Cadair commented May 31, 2022

What would a good fix to this be? I keep running into it and it's really confusing till I remember.

nden added this to the 1.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment