Skip to content

Home

Jump to bottom
P. L. Lim edited this page Nov 17, 2022 · 28 revisions

Welcome to the Jdaviz wiki!

Reviews

"This is so much nicer than DS9!" ⭐⭐⭐⭐⭐ -- Dan W.

"Why?????" -- Jonathan A. (on discovering Cubeviz can play Baby Shark GIF)

The MAST branch

The mast-dev branch of Jdaviz is a branch of Jdaviz that MAST uses for the web display of Jdaviz. The mast-dev branch is maintained by a member of ASAB. This branch will be kept in-sync with main at regular intervals. Any new updates to Jdaviz for MAST should still come through the normal workflow of a PR from a user's personal fork, to be reviewed by the team, before merging into main. mast-dev would then be subsequently updated. The operations (ops) environment of MAST will use a tagged release of Jdaviz.

The Neverending Story Points

Jesse's rule-of-thumb:

Points Meaning
13 Full sprint
8 A bit more than half a sprint
5 A few days
3 A day or two
2 Half a day
1 An hour

Where to create new tickets

This only applies to STScI developers:

  1. Check if it already exists first.
  • 1.1. If yes, comment on the existing issue. Stop here.
  • 1.2. If no, continue to Step 2.
  1. Is all the info of this issue public?
  • 2.1. If yes, continue to Step 3.
  • 2.2. If no, continue to Step 4.
  1. Open issue on both GitHub and JIRA using one of the following methods:
  • 3.1. If you want to utilize the nice GitHub feature/bug templates, open issue on GitHub. Then open a new ticket in JIRA and post GitHub issue URL there manually. Also apply the appropriate component label(s) on the JIRA ticket.
  • 3.2. If you want to utilize the nice JIRA-GitHub integration bot (no templates), create a new JIRA ticket and remember to put github under Labels field. Also apply the appropriate component label(s).
  1. Only create a new JIRA ticket without JIRA-GitHub integration bot. Also apply the appropriate component label(s). Do not use the feature described in 3.2 above. If you must have a GitHub counterpart, manually create a GitHub issue with the same title but omit all the sensitive information.

PRs that are ready for final reviews

https://github.com/spacetelescope/jdaviz/pulls?q=is%3Aopen+is%3Apr+label%3A%22Ready+for+final+review%22

PRs that need team discussion

https://github.com/spacetelescope/jdaviz/pulls?q=is%3Aopen+is%3Apr+label%3Adiscussion

Which hole is this?

Type Description
Rabbit hole Code-dive maybe one or two upstream packages. Existing solution can be found after a lot of caffeine.
Gopher hole Oh no, you need to submit a small upstream PR.
Fox hole Upstream PR is bigger than you like, or you need to submit multiple upstream PRs.
Sink hole You are venturing into unchartered waters deep in upstream engine code, possibly adding a completely new feature.
Bermuda hole Cannot be fixed without flying/relocating a dev to choice destination.
Black hole This is just not possible without divine intervention.
Clone this wiki locally