Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checksums to every request: Tigerbeetle Style #10

Open
vaibhawvipul opened this issue Jul 30, 2024 · 8 comments
Open

Add checksums to every request: Tigerbeetle Style #10

vaibhawvipul opened this issue Jul 30, 2024 · 8 comments
Assignees
@rishitc
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@vaibhawvipul
Copy link
Contributor

vaibhawvipul commented Jul 30, 2024 •
edited
Loading

  • add a check-sum to and from every request we send/receive
@vaibhawvipul vaibhawvipul added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 30, 2024
@dharanad
Copy link
Collaborator

dharanad commented Jul 30, 2024 •
edited
Loading

Interesting. I would like work on this issue.

@vaibhawvipul
Copy link
Contributor Author

@dharanad is it done? i can't remember.

@dharanad
Copy link
Collaborator

@vaibhawvipul I am yet to work on this issue. How about we timebox until this weekend ?

@vaibhawvipul
Copy link
Contributor Author

sure. Thank you.

@dharanad
Copy link
Collaborator

dharanad commented Aug 18, 2024 •
edited
Loading

Referring to https://github.com/tigerbeetle/tigerbeetle/blob/main/docs/about/architecture.md#protocol

https://github.com/tigerbeetle/tigerbeetle/blob/main/src/vsr/checksum.zig
https://github.com/tigerbeetle/tigerbeetle/blob/main/src/vsr/message_header.zig
https://github.com/tigerbeetle/tigerbeetle/blob/main/src/vsr/client.zig

@dharanad dharanad removed their assignment Aug 30, 2024
@rishitc
Copy link
Contributor

rishitc commented Sep 16, 2024

Hi @vaibhawvipul
If @dharanad is no longer working on this issue, can it be assigned to me?

Thanks

@rishitc
Copy link
Contributor

rishitc commented Oct 3, 2024

Hi @vaibhawvipul, @dierbei,
Gentle reminder: The issue still appears to be unassigned. If no one else is working on it, can it be assigned to me? 🙂

Thanks

@dierbei
Copy link
Collaborator

dierbei commented Oct 4, 2024

@rishitc Of course, feel free to play along!

If you have any questions, let's talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishitc rishitc

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vaibhawvipul @rishitc @dharanad @dierbei