Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit tests for server.rs #21

Open
dharanad opened this issue Aug 1, 2024 · 6 comments · May be fixed by #34
Open

Add Unit tests for server.rs #21

dharanad opened this issue Aug 1, 2024 · 6 comments · May be fixed by #34
Assignees
@amustaque97
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dharanad
Copy link
Collaborator

dharanad commented Aug 1, 2024

Part of #3
@dharanad dharanad mentioned this issue Aug 1, 2024
Closed
@vaibhawvipul vaibhawvipul added good first issue Good for newcomers enhancement New feature or request help wanted Extra attention is needed labels Aug 3, 2024
@dharanad
Copy link
Collaborator Author

dharanad commented Aug 4, 2024 •
edited
Loading

I would suggest we divide the unit test for server into three categories

  • leader election
  • log replication

We can start with asserting the state of server.

@amustaque97
Copy link

Hi, I would love to take this issue. Can you please assign the issue to me? I will come back with MR soon.

@vaibhawvipul
Copy link
Contributor

@amustaque97 any progress on this issue?

@amustaque97
Copy link

@vaibhawvipul I was busy for a while, will submit the MR before next week.

@amustaque97 amustaque97 linked a pull request Aug 18, 2024 that will close this issue
Draft
21 tasks
@dharanad
Copy link
Collaborator Author

Hey @amustaque97 Thanks for you efforts. I see this is long pending, Would you mind if i take over this issue ?

@amustaque97
Copy link

Hey @amustaque97 Thanks for you efforts. I see this is long pending, Would you mind if i take over this issue ?

Thanks for reaching out! Yes, please you can take it over. Apologies, I'm a bit occupied with something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amustaque97 amustaque97

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test cases for server.rs amustaque97/raft-rs
3 participants
@vaibhawvipul @dharanad @amustaque97