Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SH_BODYURI_REVERSE_SBL uses check_sh_bodyuri_a() uses non-working uridnsbl_skip_domains #69

Open
robert-scheck opened this issue Feb 8, 2024 · 1 comment

Comments

@robert-scheck
Copy link
Contributor

Moving #68 (comment) as kindly requested by @xrat in #68 (comment) into an own issue:

if (!($skip_domains->{$this_hostname})) {

does not work, @ricalfieri. SH_BODYURI_REVERSE_SBL uses check_sh_bodyuri_a() which aims to use a skip list via

my $skip_domains = $conf->{uridnsbl_skip_domains};

which suggests to be filled using uridnsbl_skip_domains, which however unfortunately has absolutely no effect (it's actually uridnsbl_skip_domain googleapis.com fonts.googleapis.com in my SpamAssassin configuration). My expectation is quite simply: Please really skip the domain as the SH.pm code makes admins believe.

@ricalfieri
Copy link
Collaborator

Hello, i'm not going to fix something on 3.4.x. If anyone wants to make a pull request with a fix it would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants