Update configuring-playbook-bot-postmoogle.md #2623
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add details about configuring custom domains for Postmoogle
spantaleev
reviewed
Apr 4, 2023
Comment on lines
+30
to
+33
| # SSL certificates configuration for custom domains | ||
| # Optional configuration, required if custom domains for postmoogle are used | ||
| matrix_ssl_additional_domains_to_obtain_certificates_for: | ||
| - "other.domain" |
There was a problem hiding this comment.
This part is incorrect.
The matrix_bot_postmoogle_domains list is already automatically injected into matrix_ssl_domains_to_obtain_certificates_for as seen here:
There's no need to add them a second time by manually adding them as additional domains in matrix_ssl_additional_domains_to_obtain_certificates_for
There was a problem hiding this comment.
Without explicitly setting this variable matrix_ssl_additional_domains_to_obtain_certificates_for it wasn't working. The same problem as here #2613 with matrix-traefik-certs-dumper-wait-for-domain remained until I added the additional domains line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add details about configuring custom domains for Postmoogle