Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message signing with multisig wallet #193

Open
mandelbit opened this issue Sep 8, 2021 · 16 comments
Open

Message signing with multisig wallet #193

mandelbit opened this issue Sep 8, 2021 · 16 comments
Labels
enhancement New feature or request low Low priority

Comments

@mandelbit
Copy link

Is message signing supported by multisig wallets in Sparrow at present?

In the Sign/Verify Message tool there seems to be no option to sign (Sign button is greyed out), only Verify. Is this a bug or unsupported feature?

@mandelbit mandelbit changed the title Message signing with multisig wallet address Message signing with multisig wallet Sep 8, 2021
@craigraw
Copy link
Collaborator

craigraw commented Sep 8, 2021

It's unsupported. Unfortunately standards for message signing are fragmented for single sig, and non-existent (afaik) for multisig. Additionally, I doubt any hardware wallets support it, and they would typically be the cosigners in a multisig.

@mandelbit
Copy link
Author

It'd be a useful feature once standards for HW multisig signing are reached.

As you say, it doesn't look like HWI supports this yet. I wonder if efforts are being made to introduce support?

@mandelbit
Copy link
Author

It's unsupported. Unfortunately standards for message signing are fragmented for single sig, and non-existent (afaik) for multisig. Additionally, I doubt any hardware wallets support it, and they would typically be the cosigners in a multisig.

What about signing with single sig HW wallets? I have the same greyed out Sign button for that.

@craigraw
Copy link
Collaborator

craigraw commented Sep 8, 2021

What about signing with single sig HW wallets? I have the same greyed out Sign button for that.

That's because you will need to perform the message signing on the device itself.

@craigraw
Copy link
Collaborator

craigraw commented Sep 8, 2021

I should add - assuming this HWW is configured as airgapped.

@mandelbit
Copy link
Author

On this particular occasion I was testing with a HW connected via USB. Funnily enough, I tried again and now the signing option is available so unfortunately I can't really help much with debugging what was wrong initially

@craigraw
Copy link
Collaborator

craigraw commented Sep 9, 2021

Ok, I'm going to close this off. If you encounter the issue again, please add another comment.

@craigraw craigraw closed this as completed Sep 9, 2021
@mandelbit
Copy link
Author

It's not clear to me why you have closed the issue. Message signing with cosigners in (HW) multisig is a legitimate and useful feature request.

@mandelbit
Copy link
Author

It's unsupported. Unfortunately standards for message signing are fragmented for single sig, and non-existent (afaik) for multisig. Additionally, I doubt any hardware wallets support it, and they would typically be the cosigners in a multisig.

What about signing with single sig HW wallets? I have the same greyed out Sign button for that.

This is a separate, resolved issue that is unrelated to the subject of this issue.

@craigraw
Copy link
Collaborator

It's not clear to me why you have closed the issue. Message signing with cosigners in (HW) multisig is a legitimate and useful feature request.

Fair enough. I've reopened it. I do suspect though that it is unlikely to be resolved anytime soon. I hope I'm wrong!

@craigraw craigraw reopened this Sep 10, 2021
@mandelbit
Copy link
Author

Hopefully won't be too long. I was quite surprised to discover that there doesn't even seem to be support in e.g. Electrum for multisig wallets w/o HW cosigners - I'd just assumed it'd be available as a standard already.

I opened an issue in the HWI repo. Maybe I'll take a stab at it at some point.

@6102bitcoin 6102bitcoin added low Low priority enhancement New feature or request labels Oct 4, 2021
@rkbtc
Copy link

rkbtc commented May 4, 2022

Hey guys, is there any update on this issue? I actually want to use this feature but its still unavailable!

@craigraw
Copy link
Collaborator

craigraw commented May 4, 2022

It's not just up to Sparrow - there are no standards for such a feature available, let alone implementations in hardware wallets. See my comment above.

@Pleb4Fun
Copy link

Pleb4Fun commented Aug 2, 2022

This missing feature was also not intuitive for me. I understand the lack of missing standards.
Maybe some "info" could be shown on hover or next to the disabled "Sign" Button?

So there is currently no way to prove to the outside world that a certain multi sig address is mine?
I can create and sign a transaction and just not broadcast it - which was enough for my usecase to just prove it to myself...

@craigraw
Copy link
Collaborator

craigraw commented Aug 2, 2022

I can create and sign a transaction and just not broadcast it

Yes, this is the best way currently

Maybe some "info" could be shown on hover or next to the disabled "Sign" Button?

Added validation for multisig addresses and a tooltip for the address field in cc8dd59:
Screenshot 2022-08-02 at 11 12 00

@Pleb4Fun
Copy link

Pleb4Fun commented Aug 2, 2022

love it - you are on fire! 🥳

(As I see in your commit the messages seem to be "hardcoded" not using i18n. Any plans for translating the Wallet or don't you think this is needed as Bitcoiners around the world do speak English? I didn't even notice it till that moment as I'm used to English as an IT guy but I could imagine there are people out there needing/preferring their local language...
Just saw that RaspiBlitz uses some nice Translation Tool for finding community help in translating the web frontend: https://mobile.twitter.com/_cstenglein_/status/1551650260942028800)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low Low priority
Projects
None yet
Development

No branches or pull requests

5 participants