Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long strings when verifying an SPDX document with deeply nested relationships #189

Open
goneall opened this issue Jul 19, 2023 · 0 comments

Comments

@goneall
Copy link
Member

goneall commented Jul 19, 2023

With the fix for verifying related elements verify will now report any Relationship as invalid if it references an invalid Element, this will create one line for the package, and one line each for the the relationships that reference the package. What makes the worse is that it is recursive - so if a package has a relationship which references a different package with a different relationship that references the package with the invalid license, you'll get a very long String for the invalid relationship with all the intermediate relationship ID's.

Note that this is somewhat expected since we do want to report every element that has an issue even if it is indirect. However, we may want to figure out a way to short the verify messages.

An ideal solution (difficult to implement) would be to report the root verify issue and list all other issues that have a relationship with the root verify issue (e.g. "Invalid license found in Package-X. This package is referenced in relationshipA, relationshipB, ...")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant