isStandardLicenseWithinText - match spaces after var rule #249
Conversation
Fixes #241 Fixes #234 Include code provided by @pmonk in #236 modified for version 2.0+ Signed-off-by: Gary O'Neall <[email protected]>
|
@goneall it appears that the new unit tests that leverage the FWIW here are the (minimal) unit tests in the original PR, though arguably more could/should be added (especially to cover the cases @sdheh identified in issue #245). |
Thanks for the catch @pmonks - it must have gotten dropped when I rebased / merged it to the 2.0 latest. I'll check to make sure the unit tests pass and add the tests back in in a subsequent commit. |
Signed-off-by: Gary O'Neall <[email protected]>
|
@pmonks - the unit tests are now included - it passes with the SPDX_JAVA_LIB_RUN_SLOW_TESTS environment variable set to true. |
|
@pmonks - Could you take another look and let me know if this is good to merge? There's also a couple other PR's if you have time for a review. |
Fixes #241
Fixes #234
Include code provided by @pmonk in #236 modified for version 2.0+
Thanks @pmonks and @sdheh for your patience and analysis / unit test help!