Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates with <<var... tags in a string without spaces does not match correctly #28

Open
goneall opened this issue Nov 23, 2020 · 1 comment
Labels
wontfix This will not be worked on

Comments

@goneall
Copy link
Member

goneall commented Nov 23, 2020

Since the license matching is tokanized and the var tags assume the regular expression is a token, it likely will not match a string in the middle of an expression.

It will also match when the template has an incorrect space (see LicenseListXML issue spdx/license-list-XML#1146).

@goneall
Copy link
Member Author

goneall commented Aug 26, 2021

This turns out to be a very challenging fix - we need access to the alt tag spacing hints which are not preserved in the template.

There are two approaches I can think of:

  • Move to a regular expression approach used by yalm
  • Use the original license XML files for doing the matching rather than using the intermediate template files

Once Yalm passes all of the tests and we have some basic performance comparisons, I plan to look into the first approach.

@goneall goneall added the wontfix This will not be worked on label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant