Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiving collections with identical names is broken #170

Closed
JR-Morgan opened this issue Sep 12, 2023 · 0 comments · Fixed by #171
Closed

Receiving collections with identical names is broken #170

JR-Morgan opened this issue Sep 12, 2023 · 0 comments · Fixed by #171
Assignees
Labels
bug Something isn't working Converter Related to the blender converter
Milestone

Comments

@JR-Morgan
Copy link
Member

Background

Blender has the requirement that all objects have unique names
For geometry Objects we were solving this by appending a numeral to the end of the object name, as per the blender default behaviour when duplicating objects.
e.g.
myObject, myObject.001, myObject.002, etc.

Right now, we don't do this for collections, so receiving multiple different collections with the same name (e.g. rhino layers at different levels of nesting, or most Navis commits)

Expected vs. Actual Behavior

Actual: All geometry is converted, but every time we convert a layer, we clear any current layers with the same name (as a primitive and flawed form of update mode)

Expect all objects to be linked to their parent collection,
and the parent collection named suitably.

This may mean we remove any update mode behaviour (which is in the pipeline to re-scope anyway see #115 )

Reproduction Steps

Receive any commit that contains multiple collections with the same name
Observe only one collection's geometry is visible after the receive. and Orphaned objects exist in file outliner.

Proposed Solution (if any)

Option 1: Implement a similar behaviour of adding a numeral
Option 2: Append the speckle ID to the collection (not ideal for any future update mode)
Option 3: Use the full path of the collection name (requires us to keep track of this)

@JR-Morgan JR-Morgan added bug Something isn't working Converter Related to the blender converter labels Sep 12, 2023
@JR-Morgan JR-Morgan added this to the 2.16 milestone Sep 12, 2023
@JR-Morgan JR-Morgan self-assigned this Sep 12, 2023
@JR-Morgan JR-Morgan linked a pull request Sep 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Converter Related to the blender converter
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant