bug: object-sender, it doesn't send empty strings or zeros

[iltabe]

Prerequisites

• I read the contribution guidelines
• I checked the documentation and found no answer.
• I checked existing issues and found no similar issue.
• I checked the community forum for related discussions and found no answer.
• I'm reporting the issue to the correct repository (see also speckle-server, speckle-sharp, specklepy, speckle-docs, and others)

What package are you referring to?

object-sender

Describe the bug

The new object sender, during serialization, it's skipping all "not values", which includes empty strings or 0:

speckle-server/packages/objectsender/src/utils/Serializer.ts

Line 56 in 08d1bff

if (!value || propKey === 'id' || propKey.startsWith('_')) continue

It is not by design right?

The .net serializer doesn't do it:

https://github.com/specklesystems/speckle-sharp-sdk/blob/ca350002ba17151585cc13564959362162294ae7/src/Speckle.Core/Serialisation/BaseObjectSerializer.cs#L321

To Reproduce

Try to send whatever property that is an empty string or a zero :) it it is not showing up in speckle.

Expected behavior

Empty strings and zero and, generally "empty" values should be pushed.

Screenshots

System Info

If applicable, please fill in the below details - they help a lot!

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Failure Logs

Additional context

Proposed Solution (if any)

if (value === undefined || propKey === 'id' || propKey.startsWith('_')) continue 

Optional: Affected Projects