Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding launch settings to play_launcher to support renaming Spel2.exe [enhancement] #21

Open
CouchCmd opened this issue Jan 30, 2022 · 6 comments

Comments

@CouchCmd
Copy link

Using hardcoded strings prevent the ability to alter the launch file names. I'm hoping to try something similar to what can be done with the stardew modding api to make it compatible for pc gamepass. The basics are your rename the base executable to something you know then rename the play_launcher.exe to Spel2.exe. This will allow the gamepass application to launch the renamed play_launcher (i have validated this works for launching it, it just crashes due to not finding spel2.exe). if i could tell play_launcher what exe is the original spelunky2 it should be able to chain.... i think. If it does work then we should be able to use mods with the gamepass/windows version of the game.

@Malacath-92
Copy link
Collaborator

It's a good idea, I can think a bit about this. However it won't help with running the Window-Store version, that is simply not compatible with our tools the Window-Store version has very different binaries (not sure why, but it's not unusual that different version have different binaries)

I would probably implement this via a playlunky_cmd_line.txt that you could pass the Spel2.exe file to or we fix something on the Modlunky end of things.

@gmjosack
Copy link
Member

I was thinking this might be useful as well in regard to downpatching. Rather than having to muck with Spel2.exe we could download alternate versions to like Versions/1.19.0c/Spel2.exe and just pass the specific exe. I was just thinking of adding something like --exe-name or whatever that would join relative to the --exe-dir option

@gmjosack
Copy link
Member

Though probably would have to keep it in the same dir for dlls and such but the point is the same :)

@Malacath-92
Copy link
Collaborator

We should always put the working dir into the root of the Spelunky installation, right? So dlls would be loaded from there.

@Dregu
Copy link
Contributor

Dregu commented Jan 31, 2022

Old versions might not run with current dlls though, fmod got updated... I might add that --exe-name for overlunky too, cause there's been a few times I wanted to do that.

@CouchCmd
Copy link
Author

CouchCmd commented Feb 4, 2022

It's a good idea, I can think a bit about this. However it won't help with running the Window-Store version, that is simply not compatible with our tools the Window-Store version has very different binaries (not sure why, but it's not unusual that different version have different binaries)

I would probably implement this via a playlunky_cmd_line.txt that you could pass the Spel2.exe file to or we fix something on the Modlunky end of things.

Thats to bad. i was hoping that since they granted access to the file structure for modding it would remain the same. seems like best bet for modding the windows version is trying to unpack and repack the exe then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants