Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom config key generator #1392

Closed
1 task done
cxy1cxy2cxy3 opened this issue Jun 27, 2022 · 2 comments
Closed
1 task done

Support custom config key generator #1392

cxy1cxy2cxy3 opened this issue Jun 27, 2022 · 2 comments
Labels
kind/enhancement New feature or request

Comments

@cxy1cxy2cxy3
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

viper always assumes a lower-cased key given.
acutally
users need upper-cased or more complex format of key to store/load

Proposed Solution

type Viper struct {
keyGenerator KeyGenerator
}

type KeyGenerator interface{
GetKey(key string) string
}

func (v *Viper) CustomKeyGenerator(kg KeyGenerator) {
v.keyGenerator = kg
}

func (v *Viper) GetKey(key string) {
if v.keyGenerator != nil {
return v.keyGenerator.GetKey(key)
}
return strings.ToLower(key)
}

Alternatives Considered

No response

Additional Information

No response

@cxy1cxy2cxy3 cxy1cxy2cxy3 added the kind/enhancement New feature or request label Jun 27, 2022
@github-actions
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark
Copy link
Collaborator

Viper is lower case for a reason and that's not going to change anytime soon.

See #1014 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants