Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the global Viper instance #1855

Open
1 task done
sagikazarmark opened this issue Jun 5, 2024 · 1 comment
Open
1 task done

Deprecate the global Viper instance #1855

sagikazarmark opened this issue Jun 5, 2024 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@sagikazarmark
Copy link
Collaborator

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

There is a global, singleton instance in Viper.

Although it makes cross-package configuration easy, it became clear that it's more a burden not just from a maintenance perspective:

  • Moving away from the setter-pattern has been challenging
  • Testing is harder with the global instance
  • Concurrent or subsequent changes may lead to unexpected behavior in a way that's nearly impossible to debug with the global instance

Proposed Solution

Deprecate the global instance. Remove it in v2.

Alternatives Considered

Provide an alternative package for people who want to continue using it.

Additional Information

No response

@sagikazarmark sagikazarmark added the kind/enhancement New feature or request label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant