Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too complicated build system #101

Open
Xottab-DUTY opened this issue Sep 28, 2018 · 2 comments
Open

Too complicated build system #101

Xottab-DUTY opened this issue Sep 28, 2018 · 2 comments

Comments

@Xottab-DUTY
Copy link
Contributor

According to this code:

#include <ClanLib/core.h>

We should move Sources/API dir to include/ClanLib dir. With this change we can build project that depend on ClanLib out of the box without doing anything. This will make compilation significantly easier.

Without it we should configure it with configure.exe before (if we don't then we'll fail to build)

I can make a PR with it. I just need to know what I need to change additionally, since it seems that just moving the folder is not enough. (we should change the build scripts)
@ArtHome12
Copy link
Contributor

And what considerations led to such an architecture?

@dpjudas
Copy link
Collaborator

dpjudas commented Sep 29, 2018

If you file a PR with this change it would get merged. You have to make sure the configure tool supports the new location though. You can probably get away with coding this by replacing "API" with "ClanLib" all over the project, including the Setup folder.

@ArtHome12 It looked better visually, that's really it.

@ArtHome12 ArtHome12 mentioned this issue Sep 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xottab-DUTY @dpjudas @ArtHome12