Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[task] benchmark Sphinx on Python 3.13 #12181

Closed
picnixz opened this issue Mar 23, 2024 · 3 comments
Closed

[task] benchmark Sphinx on Python 3.13 #12181

picnixz opened this issue Mar 23, 2024 · 3 comments

Comments

@picnixz
Copy link
Member

picnixz commented Mar 23, 2024

I'm opening an issue following #12174 so that we can track how incremental GC affects Sphinx from a memory usage (docutils is strongly affected by it as shown by python/cpython#117120 (comment) and faster-cpython/ideas#668, so I would expect the same holds for Sphinx).

I personally won't have time to play and do the benchmarks in the next weeks so I'm leaving it to anyone who wants to do it. Otherwise I'll do it when I've got time.

References

@picnixz
Copy link
Member Author

picnixz commented Apr 24, 2024

Err @AA-Turner, I assume that you don't want to benchmark it? :( (or you think this issue will stay opened for a too long time)

@AA-Turner
Copy link
Member

I was doing some quick triage this morning & it seems the GC issues for Sphinx (Docutils) have been resolved in Python.

Benchmarking will be valuable, but (a) should be for all versions, and (b) will be difficult as we need to avoid IO in benchmarks, and Sphinx doesn't have a no-IO mode.

I do admit closure is also partially due to that we have 1000+ open issues, which I am embarrassed about...

A

@picnixz
Copy link
Member Author

picnixz commented Apr 24, 2024

Ah don't worry about it! Actually, I was more interested in the new GC mechanics and how it could affect Sphinx but at least it should be lowerbounded by docutils perfs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants