Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spire-oidc does not start if federatesWith contains a down federated endpoint #197

Open
drewwells opened this issue Aug 18, 2023 · 1 comment

Comments

@drewwells
Copy link

Spire oidc logs

Example spiffeid

apiVersion: spire.spiffe.io/v1alpha1
kind: ClusterSPIFFEID
metadata:
  name: spire-system-federates
spec:
  federatesWith:
  - non-existent.example.com
  spiffeIDTemplate: spiffe://{{ .TrustDomain }}/ns/{{ .PodMeta.Namespace }}/sa/{{
    .PodSpec.ServiceAccountName }}

Repo Steps:

  • Configure clusterspiffeids.spire.spiffe.io with a federatesWith to a down spire federation endpoint
  • Attempt to start oidc
  • See the above logs and oidc container terminates

Results

Defaulted container "spiffe-oidc-discovery-provider" out of: spiffe-oidc-discovery-provider, nginx
time="2023-08-17T19:03:49Z" level=info msg="Serving HTTP" address=/run/spire/oidc-sockets/spire-oidc-server.sock network=unix
time="2023-08-17T19:03:49Z" level=debug msg="Polling started" interval=10s
time="2023-08-17T19:03:51Z" level=warning msg="Failed to fetch JWKS from the Workload API" error="rpc error: code = PermissionDenied desc = no identity issued"
time="2023-08-17T19:04:01Z" level=warning msg="Failed to fetch JWKS from the Workload API" error="rpc error: code = PermissionDenied desc = no identity issued"

Expected

oidc gives some error that federated endpoint is down, or starts despite missing one federatesWith endpoint.

ref spiffe/helm-charts#454

@drewwells drewwells closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2023
@drewwells drewwells reopened this Aug 21, 2023
@drewwells
Copy link
Author

Controller Manager should update status of the federation or spiffe id CR with the status of federated workloads. This will help enlighten the user that the warnings in spire are due to federated endpoint failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant