Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 compatibility #64

Closed
afragen opened this issue Mar 27, 2023 · 2 comments
Closed

PHP 8.1 compatibility #64

afragen opened this issue Mar 27, 2023 · 2 comments

Comments

@afragen
Copy link
Contributor

afragen commented Mar 27, 2023

In Cache::delete() I have seen occasions where the $file parameter is not defined. This results in a PHP warning in 8.1 and a fatal in 8.2.

I do not know why this occurs but it does seem to happen.

A simple update to the conditional solves the issues.
@afragen afragen mentioned this issue Mar 27, 2023
Merged
@Nicscott01
Copy link

This is the same issue I just documented: #72

Does it happen to you only when page cache is turned off in SpinupWP?

@Nicscott01 Nicscott01 mentioned this issue Dec 22, 2023
Open
@Jamesclark32
Copy link
Contributor

Resolved by #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afragen @Nicscott01 @Jamesclark32