Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed #1130

Closed
azmeuk opened this issue Jan 28, 2023 · 8 comments
Closed

RSS feed #1130

azmeuk opened this issue Jan 28, 2023 · 8 comments

Comments

@azmeuk
Copy link
Contributor

azmeuk commented Jan 28, 2023

I hate money too, and I also hate having to check ihatemoney on a regular basis to see if there is something new (though I really appreciate ihatemoney).

I suggest implementing RSS feeds of the bills for each projects.

What do you think?

@zorun
Copy link
Collaborator

zorun commented Jan 31, 2023

Interesting idea. It would require authentication though, do RSS client typically support that?

@azmeuk
Copy link
Contributor Author

azmeuk commented Feb 1, 2023

I suppose this would be simple to rely on the HTTP authentication layer.

I have seen some websites (like https://www.nextinpact.com/) generating long secret URLs for their RSS feeds. Each (paying) user is generated a long personal unguessable URL for the RSS feed of the articles. Users can invalidate and regenerate an URL as they want.

@Glandos
Copy link
Member

Glandos commented Feb 1, 2023

We already have invite code, using a secret. It can be used in the RSS feed link, but it will be global per-project, not per-user.

@azmeuk
Copy link
Contributor Author

azmeuk commented Apr 22, 2023

I attempted a basic implementation with #1158

However, we may want to handle ETag/If-None-Match and Last-Modified/If-Modified-Since HTTP headers to avoid generating the whole feed when the content has not changed between two client requests.

However in order to be able to do this, this would be needed to save the last update datetime for projects. This date would be updated at each bill addition/edition, and would be used to generate the ETag and Last-Modified headers.

As this would need a migration, I would like to discuss this before I open a PR. Would you be OK with adding such a field on Project or do you think the feature is not needed?

@azmeuk
Copy link
Contributor Author

azmeuk commented Jul 28, 2023

Fixed by #1158

@azmeuk azmeuk closed this as completed Jul 28, 2023
@azmeuk
Copy link
Contributor Author

azmeuk commented Aug 4, 2023

Out of curiosity, do you have a schedule for deploying v6.1 on ihatemoney.org?

@almet
Copy link
Member

almet commented Aug 7, 2023

@azmeuk I've planned some time for it this friday.

@almet
Copy link
Member

almet commented Aug 11, 2023

@azmeuk Just deployed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants