Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix splunk config parsing in Python 3.13 #398

Closed
wants to merge 2 commits into from
Closed

fix splunk config parsing in Python 3.13 #398

wants to merge 2 commits into from

Conversation

echipachenko
Copy link

@echipachenko echipachenko commented Oct 25, 2024 •
edited
Loading

I have read the Code of Conduct and I hereby accept the Terms

I have read the CLA Document and I hereby accept the CLA

@echipachenko echipachenko requested a review from a team as a code owner October 25, 2024 15:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@hetangmodi-crest
Copy link
Contributor

Hi @echipachenko, are you using solnlib outside Splunk environment?

@echipachenko
Copy link
Author

recheck

@echipachenko
Copy link
Author

I have read the Code of Conduct and I hereby accept the Terms

@echipachenko
Copy link
Author

I have read the CLA Document and I hereby accept the CLA

@echipachenko
Copy link
Author

recheck

sgoral-splunk
sgoral-splunk previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@sgoral-splunk sgoral-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@echipachenko echipachenko changed the base branch from main to develop October 28, 2024 19:43
@echipachenko echipachenko dismissed sgoral-splunk’s stale review October 28, 2024 19:43

The base branch was changed.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sgoral-splunk sgoral-splunk sgoral-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@echipachenko @hetangmodi-crest @sgoral-splunk