Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestApp.hardcoded_path is required even if not needed #319

Open
Res260 opened this issue Oct 24, 2024 · 1 comment · Fixed by #320 · May be fixed by #327
Open

TestApp.hardcoded_path is required even if not needed #319

Res260 opened this issue Oct 24, 2024 · 1 comment · Fixed by #320 · May be fixed by #327
Assignees

Comments

@Res260
Copy link
Contributor

Res260 commented Oct 24, 2024

TestApp.hardcoded_path is required in contentctl.yml even if we specify splunk_api_username and splunk_api_password to download the apps from splunkbase. Moreover, the serialization function for hardcoded_path serializes a None value as a 'None' of type str. I will open a PR to fix this.

@pyth0n1c
Copy link
Contributor

pyth0n1c commented Nov 4, 2024

Sorry for the delay in getting to this, as we have been helping out with some internal Splunk releases.

Thank you @Res260 , you have been hard at work with some AWESOME fixes and improvements. I admit that downloading apps from Splunkbase is a feature that used to work, but we have not used (or tested it) in quite some time. Thanks for exposing all these issue. I am going to merge all the following fixes/PRs down to a single new branch for evaluation.

Related Bugs:
#295
#319
#321

Related PRs:
#317
#320

I have opened the following PR which will be used to merge + test these changes together:
#322

I will leave these issues open until all of these are reviewed + merged and a new contentctl release it made!

@Res260 Res260 linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants