Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error in colour definition #51

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

rcastley
Copy link
Collaborator

@rcastley rcastley commented Nov 8, 2023

lime_greenred replaced with lime_green

This was breaking the O11y workshop terraform module.

@rcastley
Copy link
Collaborator Author

rcastley commented Nov 8, 2023

I have read the CLA Document and I hereby sign the CLA

@rcastley
Copy link
Collaborator Author

rcastley commented Nov 8, 2023

I have read the Code of Conduct and I hereby accept the Terms

@greatestusername
Copy link
Contributor

wow!!! My bad!

@@ -657,7 +657,7 @@ resource "signalfx_list_chart" "APM_IMM-Exec_7" {
lte = 100
}
color_scale {
color = "lime_greenred"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for this... Somehow it only happened here and not in the dashboard directory.

@greatestusername-splunk greatestusername-splunk merged commit 35779b5 into splunk:main Nov 8, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants