Add dotnet multi stage image example #52
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Thanks for your contribution @RassK ! I'll review your submission as soon as I can. |
|
I guess currently doing the CLA once is ok. If there will be more PRs, I'll check with the internal process. I have read the CLA Document and I hereby sign the CLA |
|
@github-actions recheck |
| @@ -0,0 +1,42 @@ | |||
| #See https://aka.ms/customizecontainer to learn how to customize your debug container and how Visual Studio uses this Dockerfile to build your images for faster debugging. | |||
|
|
|||
| FROM mcr.microsoft.com/dotnet/aspnet:6.0 AS base | |||
There was a problem hiding this comment.
Consider to upgrade to 8.0 (together with csproj and other places).
It will be longer valid example.
|
I have read the CLA Document and I hereby sign the CLA |
| 2023-12-01 15:34:32 | ||
| ``` | ||
|
|
||
| ## Common known issues |
There was a problem hiding this comment.
Thank you for this detailed readme and common issue fixes!
This is great!
| 1. Build the Docker image. | ||
| 1. Map a random host port (e.g.: 8181) to the container port (8080). |
There was a problem hiding this comment.
if you wanted to be really hand holdy you could have the docker commands here for folks to copy and paste.
Just a thought.
There was a problem hiding this comment.
Good idea. Added script, removed hard coded env from the dockerfile just in case.
|
|
||
| ### instrument.sh is not found | ||
|
|
||
| Linux distributions that do not recognize CRLF (Carriage Return Line Feed) file endings may encounter issues when executing the `entrypoint.sh` script. It is necessary to ensure that on such systems, `entrypoint.sh` uses LF (Line Feed) file endings, especially when the file has been modified in a Windows environment. |
There was a problem hiding this comment.
worth linking to some other resource on the difference between CRLF / LF? maybe https://en.wikipedia.org/wiki/Newline#Issues_with_different_newline_formats
Just a thought.
|
I have read the Code of Conduct and I hereby accept the Terms |
What
Provides an example demonstrating how to setup instrumentation using a heavy build image and a barebone runtime image.