Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricsHub - Hardware Dashboards #72

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

MarcDouguedroit
Copy link
Contributor

Initial version of the MetricsHub hardware dashboards

Initial version of the MetricsHub hardware dashboards
Copy link

github-actions bot commented Oct 11, 2024

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅

@MarcDouguedroit
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@MarcDouguedroit
Copy link
Contributor Author

I have read the Code of Conduct and I hereby accept the Terms

srv-gh-tools added a commit to splunk/cla-agreement that referenced this pull request Oct 21, 2024
@MarcDouguedroit
Copy link
Contributor Author

@greatestusername-splunk Can you please review this PR?

@greatestusername-splunk
Copy link
Collaborator

Hi @MarcDouguedroit sorry for the wait.

Would you mind adding a note to the bottom of your readme in the Support section you added to the effect:
Splunk does not provide support for this dashboard and users should contact MetricsHub with any support requests

We just need to make sure it's very clear that in this case this contribution is from outside of Splunk and we can't provide specific support for it.

Thanks!

@MarcDouguedroit
Copy link
Contributor Author

Hi @MarcDouguedroit sorry for the wait.

Would you mind adding a note to the bottom of your readme in the Support section you added to the effect: Splunk does not provide support for this dashboard and users should contact MetricsHub with any support requests

We just need to make sure it's very clear that in this case this contribution is from outside of Splunk and we can't provide specific support for it.

Thanks!

Hi @greatestusername-splunk

I will update the readme with your suggested content.

We created detectors for MetricsHub. I'd like to include them in this PR.
Do you know if there is a document explaining the procedure to follow to export the detectors?

@greatestusername-splunk
Copy link
Collaborator

I think the best way to export detectors is still via the API as JSON. You can find the docs for that here:
https://dev.splunk.com/observability/reference/api/detectors/latest#endpoint-retrieve-detectors-query

@MarcDouguedroit
Copy link
Contributor Author

PR updated.

Thanks @greatestusername-splunk!

Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a disclaimer in the detector readme? Thanks!

detectors/metricshub/README.md Show resolved Hide resolved
Added support information and disclaimer to the detector's README.md file.
Added MetricsHub web site's link to the detector README.md file
@greatestusername-splunk
Copy link
Collaborator

Thanks again for your contribution!

@greatestusername-splunk greatestusername-splunk merged commit 3869651 into splunk:main Nov 13, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants