Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Prefix on FeatureSpec #118

Open
richwhitjr opened this issue May 18, 2018 · 0 comments
Open

Name Prefix on FeatureSpec #118

richwhitjr opened this issue May 18, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@richwhitjr
Copy link
Contributor

It would be nice to be able to have a function on FeatureSpec that allows for a prefix on each Transformer name.

FeatureSpec.of[T].withNamedPrefix("my_prefix").required(...)

The main reason is that a common pattern recently to have many FeatureSpecs that you may want to drop or include in a job. It is nice to have a prefix on the names so later it is possible to track down which group of features this particular feature originated.

The tough part of implementing it is that internally the FeatureSpec only has a list of Transformers where name is a val. So it is not possible to add a prefix since a transformer can not be copied and the name is not mutable.

@ravwojdyla ravwojdyla added enhancement New feature or request help wanted Extra attention is needed labels May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants