Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corpus "somali-suugaan2" missing description properties #11

Closed
arildm opened this issue Jan 9, 2023 · 1 comment
Closed

Corpus "somali-suugaan2" missing description properties #11

arildm opened this issue Jan 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@arildm
Copy link
Member

arildm commented Jan 9, 2023

There are many resources with an empty string as description (e.g. gdc, sou, somali-suugaan) but the resource somali-suugaan2 is missing it completely: metadata/resource=somali-suugaan2. I don't think there's any reason to differentiate between those cases, so the API would be easier to use if we handle those cases the same when building the output. (I noticed this because there were warnings in the sbwebb-cms log.)

@arildm arildm added the bug Something isn't working label Jan 9, 2023
anne17 added a commit that referenced this issue Jan 26, 2023
@anne17
Copy link
Member

anne17 commented Jan 26, 2023

Implemented a quick fix for this in 7aa699b which should ensure empty strings for descriptions and names. Also created #12 which would be a better and more general solution.

@anne17 anne17 closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants