Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Rails 5 and Spree 3.2.0 #80

Open
priom opened this issue Feb 26, 2017 · 12 comments
Open

Doesn't work with Rails 5 and Spree 3.2.0 #80

priom opened this issue Feb 26, 2017 · 12 comments

Comments

@priom
Copy link

priom commented Feb 26, 2017

No description provided.

@mayordwells
Copy link

mayordwells commented Apr 14, 2017

I am currently using spree to create a marketplace app and It will be really nice if this could be upgraded to work with Rails 5 and Spree 3.2.0. Is there a possibility for that in coming weeks or months? @JDutil

@bradpurchase
Copy link

+1

@haxplorer
Copy link

+1
Rails - 5.1
Spree - 3.3 and above

@MateoLa
Copy link

MateoLa commented Mar 16, 2018

Hi. I've made some modifications in the gem to work with rails 5.1 and spree 3.4.4. You could find them in https://github.com/MateoLa/spree_drop_ship/releases v1-0-0.
Let me know if it is useful for someone.

@dbbooke
Copy link

dbbooke commented Apr 3, 2018

@MateoLa How do I import the upgraded to gem into my application?

@bradpurchase
Copy link

@dbbooke We did it by pointing to @MateoLa's fork in our Gemfile, like this:

gem 'spree_drop_ship', git: 'https://github.com/MateoLa/spree_drop_ship'

@dbbooke
Copy link

dbbooke commented Apr 3, 2018

I don't think you guys know how much the old gem provided by Spree-contrib has been bugging me because it didn't work lol. Appreciate it guys

@bradpurchase
Copy link

bradpurchase commented Apr 3, 2018

@dbbooke yeah, our Rails 5 upgrade has been delayed for months mostly because we didn't have the time to do this update ourselves, so really appreciate it @MateoLa!

@dbbooke
Copy link

dbbooke commented Apr 3, 2018

One more question, I am getting this error after migrating @MateoLa
WARN DurableDecorator: Spree::StockLocation#propagate_variant decoration uses an invalid SHA. The original method definition could have been tampered with! WARN DurableDecorator: Expected SHA was 68fd322da48facbdbf567a2391c2495d04c3c8bc but the provided SHA is f35b0d8a811311d4886d53024a9aa34e3aa5f8cb

should everything still be find?

@dbbooke
Copy link

dbbooke commented Apr 3, 2018

Also, the Doc_ship gem is required for spree_marketplace gem. Is anyone else having a hard time with that gem with Rails 5?

@MateoLa
Copy link

MateoLa commented Apr 6, 2018 via email

@mices
Copy link

mices commented Jul 16, 2018

Why is contrib's latest version only for spree 2.2 When are they gonna get caught up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants