Supplier Create Authorization Failure

[ZhijieWang]

Hello,

I noticed the build is actually failing and i encounter the same issue with my development instance. I did a little bit digging around.(relative new to spree but have several years with rails). I think the issue lies in the ability configuration. The supplier only allowed to "admin" which does not actually grant "supplier" the ability to create product.

However, in the spree_ship_drop gem, it is also trying to limit the capability of supplier to recreate an existing product belonging to other suppliers. Can you explain this behavior a bit?

[ZhijieWang]

Actually, I think I hunt down the problem. The latest #13 pull request from @ostraperlera actually refers to the changes made to spree_drop_ship 2-4-beta version. However, master branch still use 2-3-stable version.

Detailed discussion see spree-contrib/spree_drop_ship#57

rspect test result from latest on master

rspec ./spec/features/admin/products_spec.rb:129 # Admin - Products as Supplier creating a new product from a prototype should allow an supplier to create a new product and variants from a prototype
rspec ./spec/features/admin/products_spec.rb:152 # Admin - Products as Supplier creating a new product should allow an supplier to create a new product
rspec ./spec/features/admin/products_spec.rb:174 # Admin - Products as Supplier cloning a product should allow an supplier to clone a product
rspec ./spec/features/admin/products_spec.rb:189 # Admin - Products as Supplier cloning a product cloning a deleted product should allow an supplier to clone a deleted product
rspec ./spec/features/admin/suppliers_controller_spec.rb:22 # Admin - Suppliers as an Admin should be able to create new supplier

[Coveralls] Outside the CI environment, not sending data.

rspect test result from fb89991 on master

rspec ./spec/features/admin/products_spec.rb:174 # Admin - Products as Supplier$
rspec ./spec/features/admin/products_spec.rb:189 # Admin - Products as Supplier$
rspec ./spec/features/admin/suppliers_controller_spec.rb:22 # Admin - Suppliers$

[Coveralls] Outside the CI environment, not sending data.

Should I setup a 2-3-stable branch and 2-4-beta branch and make pull request to spree_marketplace for stability purpose? @JDutil, would you mind take a look?

[JDutil]

I'm no longer maintaining this project, but if you submit pull requests that fix the builds I will merge them.

[blacktea3937]

Hi @ZhijieWang , facing the same issue now. So what did you find out eventually? Mind sharing with the rest?

thanks!

[ZhijieWang]

@blacktea3937 It was due to a change in Spree_Drop_Ship gem model change.