Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom prefix/suffix when bulk importing OOTP apps #1743

Open
sabbyanandan opened this issue Jun 3, 2021 · 3 comments
Open

Add custom prefix/suffix when bulk importing OOTP apps #1743

sabbyanandan opened this issue Jun 3, 2021 · 3 comments
Assignees

Comments

@sabbyanandan
Copy link
Contributor

As a user, I'd like to import both RMQ and Kafka apps; while the imports work, but the registration corrupts the pallette when it loads because of the duplicate names/nodes.

See below:
image

Possible solutions:

  • Either we don't allow bulk import of both RMQ and Kafka
  • Add an option when importing to prefix/suffix with something extra to the app names
  • Highlight the apps with its unique name to avoid conflicts
@oodamien
Copy link
Member

oodamien commented Jun 7, 2021

The REST endpoint for Bulk Import uses a URL as parameter.
The URL points to a file that contains a list of apps.
We can not, on the UI side, transform the apps list (add a prefix/suffix).

@jvalkeal
Copy link
Contributor

jvalkeal commented Jun 9, 2021

You really can't even register rabbit/kafka apps with same name as it throws

java.lang.IllegalArgumentException:
Existing default application [maven://org.springframework.cloud.stream.app:file-sink-rabbit:3.0.1]
can only differ by a version but is [maven://org.springframework.cloud.stream.app:file-sink-kafka:3.0.1]

Bulk import silently drops apps which doesn't import.

@jvalkeal
Copy link
Contributor

jvalkeal commented Jun 9, 2021

@oodamien that "duplicate element" is logged here

LoggerService.error(`Group '${item.type}' has duplicate element '${item.name}'`);
if you have sink/source with same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants