New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The local storage check for the Reverse-Proxy-Feature is made against boolean not string #2015

Open

klopfdreh opened this issue Sep 25, 2024 · 0 comments · May be fixed by #2016

Labels

status/need-triage

Contributor

klopfdreh commented Sep 25, 2024

We updated to SCDF 2.11.5 and there was a small mistake I made for the check if the Reverse-Proxy-Feature is enabled.

See: https://github.com/spring-cloud/spring-cloud-dataflow-ui/blob/v3.4.6/ui/src/app/shared/api/task.service.ts#L269

it should be

UrlUtilities.fixReverseProxyUrl(url, this.localStorageService.get('reverseProxyFixActiveValue') === 'true'),

I am going to create a fix PR.

github-actions bot added the status/need-triage label

klopfdreh linked a pull request

that will close this issue

fix: reverse proxy feature local storage check #2016

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment