Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch remaining jUnit 4 tests to jUnit jupiter #4011

Open
OlgaMaciaszek opened this issue Jul 7, 2021 · 13 comments
Open

Switch remaining jUnit 4 tests to jUnit jupiter #4011

OlgaMaciaszek opened this issue Jul 7, 2021 · 13 comments

Comments

@OlgaMaciaszek
Copy link
Collaborator

No description provided.

@SivaTharun
Copy link

@OlgaMaciaszek can i work on this issue.

@OlgaMaciaszek
Copy link
Collaborator Author

@SivaTharun , thanks for reaching out. @maniotie is already working on this issue for now. If not all modules are converted, I will get back to you here.

@OlgaMaciaszek
Copy link
Collaborator Author

@maniotie is now working on reducing method and class visibility after the conversion to JUnitJupiter.

@ThomasTopuz
Copy link

Is anybody working on this?

@OlgaMaciaszek
Copy link
Collaborator Author

I don't think anybody is at the moment. They are only a few test left, but possibly the ones that were proving tricky during the previous work done by contributors. Would you like to work on it @ThomasTopuz ?

@deii
Copy link

deii commented Jun 11, 2024

The remaining tests use the deprecated ModifiedClassPathRunner class. It would be possible to replace it with ModifiedClassPathExtension, but this class has a package-access level. How could we solve this? Should I create an issue and patch in the spring-cloud-commons project?

https://github.com/spring-cloud/spring-cloud-commons/blob/main/spring-cloud-test-support/src/main/java/org/springframework/cloud/test/ModifiedClassPathExtension.java#L49

@OlgaMaciaszek
Copy link
Collaborator Author

Right, @deii. Have created: spring-cloud/spring-cloud-commons#1358.

@OlgaMaciaszek
Copy link
Collaborator Author

It's merged now. @deii @ThomasTopuz Let me know if any of you would like to work on this.

@Pjaygit
Copy link

Pjaygit commented Nov 12, 2024

@OlgaMaciaszek is this available to work?

@OlgaMaciaszek
Copy link
Collaborator Author

Yes, @Pjaygit. Would you like to work on it?

@Pjaygit
Copy link

Pjaygit commented Nov 12, 2024

Sure. Would like to try @OlgaMaciaszek

@OlgaMaciaszek
Copy link
Collaborator Author

Sounds good, @Pjaygit. Please go ahead.

@OlgaMaciaszek OlgaMaciaszek self-assigned this Nov 13, 2024
@OlgaMaciaszek OlgaMaciaszek modified the milestones: 3.0.4, 4.1.4 Nov 13, 2024
@OlgaMaciaszek
Copy link
Collaborator Author

Please add your changes against the 4.1.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

5 participants