Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement probe() in EurekaReactiveDiscoveryClient #4157

Open
OlgaMaciaszek opened this issue Jan 24, 2023 · 3 comments
Open

Implement probe() in EurekaReactiveDiscoveryClient #4157

OlgaMaciaszek opened this issue Jan 24, 2023 · 3 comments
Assignees
@MarianConstantinMarica
Labels
enhancement help wanted

Comments

@OlgaMaciaszek
Copy link
Collaborator

See spring-cloud/spring-cloud-commons#1105
@MarianConstantinMarica
Copy link

Can I work on this?

@OlgaMaciaszek
Copy link
Collaborator Author

Sure :).

@heowc
Copy link
Contributor

heowc commented May 4, 2024

I'm commenting because I think the issue needs an update. 😄

  1. Are there still plans to implement the probe() in EurekaReactiveDiscoveryClient?

It seems to have changed to reactiveProbe due to spring-cloud/spring-cloud-commons#1201.

  1. Are there no plans to implement it in DiscoveryClient as well?

I noticed that the probe() is also defined in DiscoveryClient.

See https://github.com/spring-cloud/spring-cloud-commons/blob/main/spring-cloud-commons/src/main/java/org/springframework/cloud/client/discovery/DiscoveryClient.java#L66..L68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarianConstantinMarica MarianConstantinMarica

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OlgaMaciaszek @heowc @MarianConstantinMarica